Indexing "container", like zip, 7z, rar files crashes Everything

[elcato]

Hi there again. Sorry for holding the crashes torch again .
I was trying to use the feature for indexing archive files, and I had several crashes and still having them.
update:
Using the logging feature i was able to find the file, it was a corrupted file.
So corrupted files causes this feature to crash Everything.

A mitigation solution:
- I don't know it if it is possible to add this as a quick fix release, but an "If condition" added to code that reads the archive, and if the archive is corrupted then skip it, add it to a text file for later processing, so the program wouldn't crash, this will save the time not redoing the same indexing every time Everything crashes.
- Maybe also a option to automatically save progress every number of scanned files, like every 500 scanned files. So even if it crashed, you still have the option to quickly resume the scanning, and also quickly pinpointing the corrupted file, and continue to find the next corrupted file.

I am using the latest version Version 1.5.0.1387a (x64), but the crash was also in the Version 1.5.0.1383a (x64).

Also I noticed that when I updated to 1.5.0.1387a (x64), my old the session including windows and tabs was not restored correctly. I had alot of windows and tabs opened before the update. But after the update I had only like 4 or 5 windows restored.
Any thoughts about these two problems void.

I have a question also void: how can I run a command line for every file in the search or every file I select, but not all at once ?
I mean :
1- I select files
2- I run the command line
3- Everything run the command line on first file, and waits until the command finishes. Like waiting for an exit code of "0", so it knows that the command line was successful
4- Everything runs the same command line again, and if an error occurs, then it will save it to a text or log file for later processing, then it will continue for other files so it doesn't lost its progress.
Can I achieve this use case ?

[therube]

1- I select files ...

You could run a batch file (even assigning a hotkey to it) from within Everything.

pseudo-code (& it is NOT correct), findbatZIPs.bat:

Code: Select all

for  %%n in  (*.7z) DO (
  7z.exe -bso0 -bsp0 -bse0  t  %%n
  echo %%n: %errorlevel%
  pause)

(I'm guessing %errorlevel% is coming from the echo & not from the 7z.exe command?)

it was a corrupted file

Sample file you could post?

my old the session including windows and tabs was not restored correctly

Have a backup of Session-1.5a.json from BEFORE the update to 1387a that you could post/send to Void?

[void]

Thank you for the issue report elcato,

Please send a mini crash dump:

• Please keep the crash dialog open.
• Download Process Explorer from Microsoft:
  https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer
• In Process Explorer, select Everything64.exe (If there is two, select the one using the most memory)
• Right click Everything64.exe and under Create Dump, select Create Mini Dump.
• Choose a filename and click Save.
• Please attach this file in a bug report.

- I don't know it if it is possible to add this as a quick fix release, but an "If condition" added to code that reads the archive, and if the archive is corrupted then skip it, add it to a text file for later processing, so the program wouldn't crash, this will save the time not redoing the same indexing every time Everything crashes.

Best solution would be to fix the issue causing the crash.
Everything uses third party libraries to read most archive properties.

- Maybe also a option to automatically save progress every number of scanned files, like every 500 scanned files. So even if it crashed, you still have the option to quickly resume the scanning, and also quickly pinpointing the corrupted file, and continue to find the next corrupted file.

I will consider an option to do this.
I have plans to move the property indexer to a separate process in a future release.

For now, to manually save your index to disk:

Type in the following search and press ENTER:

/save-db

Tools -> Options -> Advanced -> db_auto_save_type

Also I noticed that when I updated to 1.5.0.1387a (x64), my old the session including windows and tabs was not restored correctly. I had alot of windows and tabs opened before the update. But after the update I had only like 4 or 5 windows restored.

Some sessions settings did change which may have caused the issue.
I will look into this some more..

I have a question also void: how can I run a command line for every file in the search or every file I select, but not all at once ?

Everything runs each file separately.
Unfortunately, Everything doesn't wait for the executed program to return.
The exit code is not known.

You may want to setup a custom open command to run a BAT that logs non-zero exit codes.

[therube]

Who would have ever known that % needs to be, ! (in errorlevel), !.

findbatZIPs.bat:

Code: Select all

:: needed for the "multi-line" FOR (i believe)
@echo off
setlocal EnableDelayedExpansion

for %%i in (*.arj *.7z *.zip *.rar) do (
	echo checking .. %%i
	7z.exe t %%i 2>&1 > nul
	if !errorlevel! GTR 1  echo ERROR: !errorlevel!, %%i ------------------- is *BAD*
   )
pause

And you could have the output go to a file by appending something like,

| tee -a badzips.TXT

to the if !errorlevel! line (or by other means).

Oh, & I did redirection of the output from 7-zip, but you could also use something like in the first example.

[elcato]

Who would have ever known that % needs to be ...

Thank you therube for the reply and suggestion , I will try to test it.

Please send a mini crash dump ..

Thank you void for the reply and suggestion. I will try to send a crash report as soon as I have a crash. I would like to send a crash file as a sample but I deleted the corrupted files.
I will try to recreate the crash and get a sample file and then upload it as soon as I can.